-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DevOps to cache conda and fix attributes not being preserved with xarray > 2023.3.0
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Constraint `xesmf` in `ci.yml`
tomvothecoder
changed the title
Update build workflow to cache conda env correctly
[DevOps]: Update build workflow to cache conda env correctly
Apr 27, 2023
- Update `_logger.py` module to avoid propagating logger messages multiple times - Update `TemporalAccessor._set_data_var_attrs` try and except statement to a `.get()`
tomvothecoder
changed the title
[DevOps]: Update build workflow to cache conda env correctly
Update DevOps to cache conda and fix attributes not being preserved with May 11, 2023
xarray > 2023.3.0
tomvothecoder
added
the
type: bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
label
May 11, 2023
tomvothecoder
commented
May 11, 2023
@@ -1138,7 +1138,7 @@ def _group_average( | |||
# dimension) shape of the `weights` DataArray to the | |||
# multi-dimensional shape of its corresponding data variable. | |||
weights, _ = xr.broadcast(self._weights, dv) | |||
weights = xr.where(np.isnan(dv), 0.0, weights) | |||
weights = xr.where(dv.copy().isnull(), 0.0, weights) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line resolves #458. In the latest version of xarray, xr.where()
with np.isnan(dv)
deletes the attributes on dv
. The fix is to replace np.isnan(dv)
with dv.copy().isnull()
. Not exactly sure what changed in xarray.
- Bump xarray to latest version in conda envs
tomvothecoder
changed the title
Update DevOps to cache conda and fix attributes not being preserved with
Update DevOps to cache conda and fix attributes not being preserved with Aug 17, 2023
xarray > 2023.3.0
xarray >= 2023.4.2
tomvothecoder
changed the title
Update DevOps to cache conda and fix attributes not being preserved with
Update DevOps to cache conda and fix attributes not being preserved with Aug 17, 2023
xarray >= 2023.4.2
xarray > 2023.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
type: devops
Testing, CI/CD, systems configuration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build_workflow.yml
ci.yml
xesmf >0.6.3
to avoid import error withesmpy
_logger.py
bounds.py, dataset.py, regridder/base.py
temporal.py
.get()
statement.where()
causing attributes to be deleted on the data variable (Closes [Bug]: Attributes are not being preserved with temporal averaging APIs usingxarray > 2023.3.0
#458)tests/test_*.py
Checklist
If applicable: